Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do both pause and inFailOver exist? #56

Open
stephenwithav opened this issue Jun 10, 2018 · 2 comments
Open

Why do both pause and inFailOver exist? #56

stephenwithav opened this issue Jun 10, 2018 · 2 comments

Comments

@stephenwithav
Copy link

pause and inFailOver are both only true when actively failing over, so can't we remove pause and just use inFailOver to signal that condition?
@davecramer
Copy link
Contributor

I suppose we could. Good catch

@stephenwithav
Copy link
Author

stephenwithav commented Jun 11, 2018 •
edited
Loading

Thank you, @davecramer.

Removing pause would let us extract the goroutine in func main into its own function, so it looks like a win-win scenario. Hopefully Jeff and Adam will agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenwithav @davecramer