Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single days, half days and how much is left #75

Open
chris-asdf opened this issue Aug 13, 2022 · 17 comments
Open

Single days, half days and how much is left #75

chris-asdf opened this issue Aug 13, 2022 · 17 comments

Comments

@chris-asdf
Copy link

Hi,

this app seems to be a nice addition to my current way to track my work time. But, three questions remain:

  1. How can I conveniently add one single holiday /day off? If the start and end date are the same, there is a zero in front of the entry
  2. Is it possible to add half days?
  3. How can I enter the number of holidays I have for a year and how much is left?

Thanks in advance, all the best
Chris

@CrazyMarvin
Copy link
Contributor

Hey,
thanks for your feedback. 😊

  1. I don't see this. When I add a holiday for August 15 I see a 15 in front of the entry. May you please share a screenshot?

  2. No, that is not possible at the moment. What do you think of adding this feature, @arafaatqureshi & @amarradi?

  3. This feature is planned for one of the next releases.

@arafaatqureshi
Copy link
Contributor

will be updating the total holidays count in the upcoming release. Thanks

@chris-asdf
Copy link
Author

chris-asdf commented Aug 14, 2022 via email

@unbiaseduser
Copy link
Contributor

Hello @chris-asdf, I have fixed the date display for vacations with a single day.
unbiaseduser@7da5b7a
Can you try adding such a holiday with this APK? In your case, the date displayed should be "01" instead of "0".
You have to uninstall the original app before installing this one!
app-debug.zip

@arafaatqureshi
Copy link
Contributor

@chris-asdf we will be looking for some other way too, but for now as you have to enter the end date as well. so, the same date would be the end date for the single holiday. and then save it, it will let you save .

@unbiaseduser
Copy link
Contributor

@arafaatqureshi Are you going to check my code?

@arafaatqureshi
Copy link
Contributor

@unbiaseduser sure.

@chris-asdf
Copy link
Author

Hi,

thanks @unbiaseduser for fixing. I just give the apk you attached a try and this will do it for me for the single days.
I could also imagine a way of entering no end date if a corresponding checkbox is clicked, that defines if it's a single holiday. But that's not that important.

Also thanks - whoever did this 😃 - for adding the feature with the configurable number of holidays.

Any chance for half days?

All the best
Chris

@unbiaseduser
Copy link
Contributor

@chris-asdf you're welcome. Also I would like to mention that the broken date display issue and the feature to conveniently add 1 holiday issue are completely different issues. Which means that if I were to add such feature without fixing the date display, it would still be broken.
Speaking of that feature, I might add it somewhere down the line.
(As for the half days one, I haven't got any ideas how to implement it yet.)

@AkechiShiro
Copy link

AkechiShiro commented Oct 25, 2022

Hey, what about adding half-days ? Could I help on making this feature ? I'm not sure, I can do it soon tho, but I can always keep struggling (which is always great with open source stuff)

@unbiaseduser
Copy link
Contributor

Hey, what about adding half-days ? Could I help on making this feature ? I'm not sure, I can do it soon tho, but I can always keep struggling (which is always great with open source stuff)

Sure, go for it, no need to ask

@CrazyMarvin
Copy link
Contributor

Thanks for your offer to help, @AkechiShiro! That's awesome!

@CrazyMarvin
Copy link
Contributor

Are you still up for it, @AkechiShiro?
Next month is Hacktoberfest by the way. 😅

@AkechiShiro
Copy link

Hi @CrazyMarvin

Very sorry for not having gave any update on this, I completely forgot about this, and got busy in life on a few others projects, at the moment I'm short on storage space, but would need Android Studio to properly develop this feature, I believe.

I will definitely try and take a look at what needs to be modified, but this will take me time as I'm not familiar with the code base at all.

@CrazyMarvin
Copy link
Contributor

Are you interested to work on the feature to support half days, @karimapps?

@AkechiShiro
Copy link

I'm sorry I couldn't get to take a full stab at this issue @CrazyMarvin

@CrazyMarvin
Copy link
Contributor

I'm sorry I couldn't get to take a full stab at this issue @CrazyMarvin

Don't worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants