-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single days, half days and how much is left #75
Comments
Hey,
|
will be updating the total holidays count in the upcoming release. Thanks |
Hi,
that's great news, that you are planning to add these features!
Regarding the single day I've attached two screenshots when I add a vacation for 08/01 . On the date picker screen I'm not allowed to save it until I set an end date, which I set also to 08/01.
All the best
Chris
![Screenshot_20220814-143255_Vacation Days](https://user-images.githubusercontent.com/24594385/184551683-f21e796b-e884-40dc-857d-e2d510b4a3e4.jpg)
![Screenshot_20220814-143301_Vacation Days](https://user-images.githubusercontent.com/24594385/184551696-f7b090b2-8197-4fe3-b730-024c4bfcc681.jpg)
|
Hello @chris-asdf, I have fixed the date display for vacations with a single day. |
@chris-asdf we will be looking for some other way too, but for now as you have to enter the end date as well. so, the same date would be the end date for the single holiday. and then save it, it will let you save . |
@arafaatqureshi Are you going to check my code? |
@unbiaseduser sure. |
Hi, thanks @unbiaseduser for fixing. I just give the apk you attached a try and this will do it for me for the single days. Also thanks - whoever did this 😃 - for adding the feature with the configurable number of holidays. Any chance for half days? All the best |
@chris-asdf you're welcome. Also I would like to mention that the broken date display issue and the feature to conveniently add 1 holiday issue are completely different issues. Which means that if I were to add such feature without fixing the date display, it would still be broken. |
Hey, what about adding half-days ? Could I help on making this feature ? I'm not sure, I can do it soon tho, but I can always keep struggling (which is always great with open source stuff) |
Sure, go for it, no need to ask |
Thanks for your offer to help, @AkechiShiro! That's awesome! |
Are you still up for it, @AkechiShiro? |
Hi @CrazyMarvin Very sorry for not having gave any update on this, I completely forgot about this, and got busy in life on a few others projects, at the moment I'm short on storage space, but would need Android Studio to properly develop this feature, I believe. I will definitely try and take a look at what needs to be modified, but this will take me time as I'm not familiar with the code base at all. |
Are you interested to work on the feature to support half days, @karimapps? |
I'm sorry I couldn't get to take a full stab at this issue @CrazyMarvin |
Don't worry. |
Hi,
this app seems to be a nice addition to my current way to track my work time. But, three questions remain:
Thanks in advance, all the best
Chris
The text was updated successfully, but these errors were encountered: