Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASMINST-6711 - Command Mismatch When Setting up SNMP on Dell and Mellanox switches #5574

Merged
merged 2 commits into from
Dec 5, 2024
Merged

CASMINST-6711 - Command Mismatch When Setting up SNMP on Dell and Mellanox switches #5574

merged 2 commits into from
Dec 5, 2024

Conversation

spillerc-hpe
Copy link
Contributor

Description

Correct syntax of commands to configure SNMPv2 for Dell and Mellanox switches.

Checklist

  • If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
  • If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
  • My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

@spillerc-hpe spillerc-hpe requested review from a team as code owners November 28, 2024 11:40
@spillerc-hpe
Copy link
Contributor Author

/backport release/1.5

@github-actions GitHub Actions
Copy link
Contributor

Backporting into branch release/1.5 was successful. New PR: #5575

@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
@spillerc-hpe
Copy link
Contributor Author

/backport release/1.4

@github-actions GitHub Actions
Copy link
Contributor

Backporting into branch release/1.4 was successful. New PR: #5576

@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
rustydb
rustydb reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@rustydb rustydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits to match other switch code snippets, and a "table of content" question.

operations/network/management_network/dell/snmp-community.md Outdated Show resolved Hide resolved
operations/network/management_network/dell/snmp-community.md Outdated Show resolved Hide resolved
operations/network/management_network/dell/snmp-community.md Outdated Show resolved Hide resolved
operations/network/management_network/dell/snmp-community.md Show resolved Hide resolved
operations/network/management_network/dell/snmp-community.md Outdated Show resolved Hide resolved
@spillerc-hpe @rustydb
Apply suggestions from code review
170a67b 
Co-authored-by: Russell Bunch <[email protected]>
Signed-off-by: Chris Spiller <[email protected]>
@spillerc-hpe spillerc-hpe requested a review from rustydb December 5, 2024 09:46
@rustydb rustydb merged commit ff29b09 into release/1.6 Dec 5, 2024
8 checks passed
@rustydb rustydb deleted the CASMINST-6711 branch December 5, 2024 18:14
Srinivas-Anand-HPE pushed a commit that referenced this pull request Dec 20, 2024
@spillerc-hpe @rustydb @Srinivas-Anand-HPE
CASMINST-6711 - Command Mismatch When Setting up SNMP on Dell and Mel…
833d021 
…lanox switches (#5574)

* CASMINST-6711 - Command Mismatch When Setting up SNMP on Dell and Mellanox switches

* Apply suggestions from code review

Co-authored-by: Russell Bunch <[email protected]>
Signed-off-by: Chris Spiller <[email protected]>

---------

Signed-off-by: Chris Spiller <[email protected]>
Co-authored-by: Russell Bunch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrockershousen nrockershousen nrockershousen approved these changes

@rustydb rustydb rustydb approved these changes

@jnowicki-hpe jnowicki-hpe Awaiting requested review from jnowicki-hpe jnowicki-hpe is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@mharding-hpe mharding-hpe Awaiting requested review from mharding-hpe mharding-hpe is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@shunr-hpe shunr-hpe Awaiting requested review from shunr-hpe shunr-hpe is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@GunashekarKM GunashekarKM Awaiting requested review from GunashekarKM GunashekarKM is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@SavioJoshua SavioJoshua Awaiting requested review from SavioJoshua SavioJoshua is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@sfkramer sfkramer Awaiting requested review from sfkramer sfkramer is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@alexanderkingh alexanderkingh Awaiting requested review from alexanderkingh alexanderkingh is a code owner automatically assigned from Cray-HPE/docs-csm-reviewers

@brookshire brookshire Awaiting requested review from brookshire brookshire is a code owner automatically assigned from Cray-HPE/ssi-reviewers

@kkelling-hpe kkelling-hpe Awaiting requested review from kkelling-hpe kkelling-hpe is a code owner automatically assigned from Cray-HPE/ssi-reviewers

@don-bahls-hpe don-bahls-hpe Awaiting requested review from don-bahls-hpe don-bahls-hpe is a code owner automatically assigned from Cray-HPE/ssi-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spillerc-hpe @rustydb @nrockershousen