Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-7349 remove kubeconfig from IUF SAT template #5421

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

leliasen-hpe
Copy link
Contributor

Description

SAT is printing information that is unexpected by IUF. Because of this, IUF management-nodes-rollout is failing because it is not able to parse the output.

To fix this we should allow SAT to load the kubeconfig from the system and get the VCS password itself. Doing this, will cause SAT not to output the VCS password that is being passed in.

More detailed description

SAT being able to load the kubeconfig from the system is new in CSM 1.5 which is why this was not implemented in the first place. In CSM 1.6, a bad kubeconfig was being passed to SAT (because of a k8s 1.24 change) which prevented SAT from getting the necessary VCS password. A workaround solution was recently put in place to provide the VCS password to SAT. However, because SAT is able to load the kubeconfig from the system, there is no need to pass in the vcs password or provide a bad kubeconfig. This PR removes the vcs password and kubeconfig that are provided to SAT. As a result of this, SAT is able to output the expected information.

Testing

This output is from the current, problematic SAT template. It is creating bad output by printing the vcs password

/tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= /tmp/vcs_passwd g4cQLgD-GJaEVsfQFbYwFka-eL1dX5AO6ZpAL662QFo= { "configurations": [ { "name": "compute-1.0.0-8443" }, { "name": "lnet-1.0.0-8443" }, { "name": "uan-1.0.0-8443" } ] }

The output below is the output from the updated template in this PR.

{ "configurations": [ { "name": "compute-1.0.0-8443" }, { "name": "lnet-1.0.0-8443" }, { "name": "uan-1.0.0-8443" } ] }

Checklist

  • If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
  • If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
  • My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

@leliasen-hpe leliasen-hpe requested a review from a team as a code owner October 2, 2024 21:41
Copy link
Contributor

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@haasken-hpe
Copy link
Contributor

If anybody wants more detail about the changes added to SAT to support loading the in-cluster Kubernetes config, see CRAYSAT-1656. It was implemented in CSM 1.5/SAT 2.6.

Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustydb rustydb merged commit 6a92876 into release/1.6 Oct 4, 2024
8 checks passed
@rustydb rustydb deleted the CASMTRIAGE-7349 branch October 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants