MTL-1832 #5384
Merged
MTL-1832 #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdavis-prof
requested review from
haroldlongley,
mharding-hpe,
spillerc-hpe,
GunashekarKM,
SavioJoshua,
sfkramer,
alexanderkingh,
brookshire,
kkelling-hpe and
don-bahls-hpe
2 tasks
jpdavis-prof
force-pushed
the
MTL-1832
branch
from
453ef7e to
4e8ca19
Compare
rustydb
requested changes
Sep 20, 2024
jpdavis-prof
force-pushed
the
MTL-1832
branch
4 times, most recently
from
8a84ba2 to
e92ff09
Compare
rustydb
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
We should make a JIRA, one for each of these future TODOs:
- Adding a flag to
csithat can dump themeta-dataanduser-datafor nodes so we can remove the duplication between this and https://github.com/Cray-HPE/cray-site-init/blob/bc2a8d569fd2a0c2a495c1f82e5f01c2ea9ea53e/pkg/cli/config/initialize/disks.go - A dependent JIRA for removing this in 1.6.1/1.7.0
2 tasks
rustydb
approved these changes
Oct 3, 2024
The above suggestions / changes were added to cray-site-init here: Cray-HPE/cray-site-init#426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to:
MTL-1832 cray-site-init#423
https://github.com/Cray-HPE/node-images/pull/1157
If I added any command snippets, the steps they belong to follow the prompt conventions (see [example][1])
If I added a new directory, I also updated
.github/CODEOWNERSwith the corresponding team in [Cray-HPE][2]My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA