Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messages] wrong label for expired request #5128

Open
bakeiro opened this issue Nov 9, 2024 · 3 comments
Open

[messages] wrong label for expired request #5128

bakeiro opened this issue Nov 9, 2024 · 3 comments
Assignees

Comments

@bakeiro
Copy link
Contributor

bakeiro commented Nov 9, 2024

context:
Request is expired, but actually says "this request is still pending" which is not true

toDo:

  • if it's expired should say "request expired"
  • do it in red color

image

@Krishnag09
Copy link
Contributor

could you paste the request being sent from the front end in this case?

@nabramow nabramow moved this from Ready to In Progress in Couchers Engineering 💻 Jan 8, 2025
@nabramow
Copy link
Member

@Krishnag09 Looks like this:

export namespace SendHostRequestMessageReq {
  export type AsObject = {
    hostRequestId: number,
    text: string,
  }
}

@bakeiro
Copy link
Contributor Author

bakeiro commented Jan 31, 2025

@nabramow I guess I close this in favor of #5515?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants