Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] JWT authentication #516

Open
mraerino opened this issue Feb 2, 2025 · 1 comment
Open

[Feature] JWT authentication #516

mraerino opened this issue Feb 2, 2025 · 1 comment

Comments

@mraerino
Copy link

mraerino commented Feb 2, 2025

Is your feature request related to a problem? Please describe.

We would like to use SSO with ClickHouse, which is not currently possible in open-source clickhouse.

Describe the solution you'd like

When using the Grafana clickhouse plugin, the Grafana identity is passed in a HTTP header (X-Id-Token, issue) as a JWT.

It would be great to be able to authenticate requests via this token instead of just basic auth or query params.

Describe alternatives you've considered

JWT auth is not currently supported in open-source clickhouse: ClickHouse/ClickHouse#68634

Additional context

I would be willing to implement this support if you agree it's a useful feature.

@mga-chka
Copy link
Collaborator

mga-chka commented Feb 4, 2025

Hi,
Thanks for presenting the feature. If you want to provide the JWT feature, feel free to it.

But, please, put the JWT logic on specific files. We've started in the past a work to split the "monolithic files" into smaller files with clear ownership but we didn't have time to finish (yet).

nb: Don't forget to add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants