Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Kotlin DSL #5

Closed
Iggy82 opened this issue Nov 9, 2023 · 4 comments · Fixed by #6
Closed

Gradle Kotlin DSL #5

Iggy82 opened this issue Nov 9, 2023 · 4 comments · Fixed by #6
Assignees

Comments

@Iggy82
Copy link

Iggy82 commented Nov 9, 2023

Hallo, after migrating my build scripts to Kotlin DSL, the properties like appSignatures, obfuscationKey etc. cannot be set. I think it's because "SecretsVaultExtension" is not public.
It would be great if you could fix it. Thank you very much.

@agabeyalioglu
Copy link
Collaborator

Hello, if you are trying to set the properties using the = operator, it was not supported in Kotlin DSL until Gradle 8.2 (https://blog.gradle.org/simpler-kotlin-dsl-property-assignment). You can either update your gradle wrapper version or use the setter syntax obfuscationKey.set("XXX") instead of obfuscationKey = "XXX"

If this does not resolve your issue could you please share more information, like error message and related code snippet.

@agabeyalioglu agabeyalioglu self-assigned this Nov 14, 2023
@agabeyalioglu agabeyalioglu linked a pull request Nov 16, 2023 that will close this issue
agabeyalioglu added a commit that referenced this issue Nov 16, 2023
agabeyalioglu added a commit that referenced this issue Nov 17, 2023
#5: Make plugin extensions visible in Kotlin DSL
@Iggy82
Copy link
Author

Iggy82 commented Nov 18, 2023

I'm using Gradle 8.2.1. The SecretsVaultExtension is not public and therefore I cannot set a property. I have attached a screenshot of Android Studio
secretsVault

But as I see in the comments above it should be fixed with release 0.1.1. Do you know when it's available?

Thank you.

@agabeyalioglu
Copy link
Collaborator

agabeyalioglu commented Nov 27, 2023

Hello, 0.1.1 is now released. Can you update your version and try again? @Iggy82

@Iggy82
Copy link
Author

Iggy82 commented Nov 28, 2023

Great. I have just tested it and it works.
Also thank you very much for a great plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants