Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request}: Allow agents to use a local source for actor headshot images #269

Open
fourstix opened this issue Aug 3, 2023 · 13 comments
Labels
enhancement New feature or request

Comments

@fourstix
Copy link

fourstix commented Aug 3, 2023

Is your feature request related to a problem? Please describe.
The IAFD website has recently been refusing head-shot image requests with http response code 403 "Forbidden". Other times IAFD doesn't have an actor's head-shot or sometimes it has the wrong actors head shot. The result is several actors no longer have head-shots when a film is scraped. This is the result of the source website denying requests and not the fault of a particular agent.

Describe the solution you'd like
I would like to have a location (like a sub-directory) defined somewhere where one could load actor head shot images. When the Plex agent goes to associate a head shot with an actor in the movies cast, the agent would first check this location for an image. If it is found, the agent would use that image, instead of requesting an image from IAFD.

A nice to have would be to store the images received from IAFD in this location so that future requests would not need to go to IAFD. This should reduce the web traffic that is causing IAFD to deny image requests.

Describe alternatives you've considered
Here's an example of how the Gay Adult NFO Importer agent does this.
The Gay Adult NFO Importer agent allows one to provide a URL to search for actor head-shots. By setting up a local web server and setting this agent to use http://localhost/nfo as the URL. The Gay Adult NFO agent will load actor head-shots from images named Firstname_Lastname.jpg for example if the actor is listed as "Johnny Rapid" in the cast list in the nfo file for a film then the URL for the actor image is http://localhost/nfo/Johnny_Rapid.jpg.

However since not everyone can set up a local web server and there already is a lot of work done to read files in directories under the _PGMA directory. I think it would probably be best to create a directory under _PGMA and allow one to put head shot images there under some kind of naming scheme, like the NFO naming scheme.

Additional context
I'll be happy to help test or contribute to this feature any way I can.

@fourstix fourstix added the enhancement New feature or request label Aug 3, 2023
@JPH71
Copy link

JPH71 commented Aug 3, 2023 via email

@fourstix
Copy link
Author

fourstix commented Aug 3, 2023

If I remember correctly, the Gay Adult NFO agent tries to load it from the URL supplied, then it looks for local files stored in the folder that the nfo file is in. Then finally, it tries IAFD. I think Cloudflare broke this agent's IAFD logic the same way that it broke the other agents. So the logic added to the other agents for Cloudflare, probably needs to be added to this agent.

@JPH71
Copy link

JPH71 commented Aug 3, 2023 via email

@fourstix
Copy link
Author

fourstix commented Aug 3, 2023

I don't have any list. The only one I'm aware is the GAnfoMoviesImporter.bundle agent.

In the /Contents/Code/init.py module, the function getIAFDActorImage() probably needs to be updated.

@fourstix
Copy link
Author

fourstix commented Aug 3, 2023

Oh, the underscores in the module file name around "init" turned into "Bold" highlighting.

@JPH71
Copy link

JPH71 commented Aug 3, 2023 via email

@fourstix
Copy link
Author

fourstix commented Aug 8, 2023

@JPH71 Kudos to you, Jason. You've done such an amazing job fixing the 403 errors that I'm not sure if this feature is needed anymore. It's probably more of a nice to have at this point.

I can use the Gay Adult NFO agent with a local web server for the few films that can't be found by the GEVI, AEBN, GayHotMovies and GayEmpire agents.

@JPH71
Copy link

JPH71 commented Aug 8, 2023 via email

@fourstix
Copy link
Author

Bumping this request, since Cloudflare is blocking requests again.

It would be nice if /_PGMA/Cast/Face directory was searched before IAFD.

@ms52538
Copy link

ms52538 commented Jul 28, 2024 via email

@JPH71
Copy link

JPH71 commented Jul 28, 2024 via email

@fourstix
Copy link
Author

Hi,
Any updates on this? I'm getting 403 errors again from IAFD for the actor's head shots. Should I open up a new issue for the 403 errors?

@JPH71
Copy link

JPH71 commented Nov 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants