Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements not functioning correctly between traits #73

Open
royalcw opened this issue Jun 25, 2018 · 2 comments
Open

Requirements not functioning correctly between traits #73

royalcw opened this issue Jun 25, 2018 · 2 comments
Labels
bug Something isn't working Medium Priority Reskillable Change probably required in Reskillable to be able to support of fix

Comments

@royalcw
Copy link

royalcw commented Jun 25, 2018

Two traits:

var ic2_access_01 = mods.compatskills.GameStageUnlockable.addGameStageUnlockable("ic2_unlock", "ic2_unlock", 2, 0, "compatskills:engineer", 1, "not|trait|compatskills:botania_unlock");

var botania_access_01 = mods.compatskills.GameStageUnlockable.addGameStageUnlockable("botania_unlock", "botania_unlock", 0, 0, "reskillable:magic", 1, "not|trait|compatskills:ic2_unlock");

The one created first does not actually take the "not|trait|compatskills:XXXXXXX_unlock". The second trait will take "not|trait|compatskills:XXXXXXX_unlock". I believe it is due to the order they are created in because if you swap them the requirement only stays with the second trait created.

The reskillable.cfg does show the traits correctly...even deleted the file and let it remake but only one trait shows the actual requirement in game depending on which is made second in the script.

"compatskills:botania_unlock" {
B:Enabled=true
S:Requirements <
not|trait|compatskills:ic2_unlock
>
I:"Skill Point Cost"=1
I:"X-Pos [0-4]:"=0
I:"Y-Pos [0-3]:"=0
}

"compatskills:ic2_unlock" {
B:Enabled=true
S:Requirements <
not|trait|compatskills:botania_unlock
>
I:"Skill Point Cost"=1
I:"X-Pos [0-4]:"=2
I:"Y-Pos [0-3]:"=0
}

Will attach a screen shot of each trait in the gui.

@royalcw
Copy link
Author

royalcw commented Jun 25, 2018

image

and

image

@pupnewfster pupnewfster added bug Something isn't working Medium Priority Reskillable Change probably required in Reskillable to be able to support of fix labels Jun 27, 2018
@pupnewfster
Copy link
Contributor

I am leaving this open, as there is still the issue when it is done purely through the reskillable config with reskillable traits, but it is technically now possible (as of 1.14.1) to do using the bracket handlers to override it afterwards. (It may still throw a warning/error in the console saying it doesn't exist but it should properly work).

<unlockable:compatskills:botania_unlock>.setRequirements("not|trait|compatskills:ic2_unlock");

Sometime after the call creating the ic2_unlock skill is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Medium Priority Reskillable Change probably required in Reskillable to be able to support of fix
Projects
None yet
Development

No branches or pull requests

2 participants