Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intuitive range building #129

Closed
pH14 opened this issue Jul 10, 2019 · 0 comments · Fixed by #164
Closed

intuitive range building #129

pH14 opened this issue Jul 10, 2019 · 0 comments · Fixed by #164

Comments

@pH14
Copy link
Collaborator

pH14 commented Jul 10, 2019

In #122 (comment) I was surprised to find that RangeOptionBuilder::from(subspace.range()) does not actually build a range over a subspace! This is a tricky gotcha, and we should make the range building as intuitive as possible.

To spitball one possibility: we could create a separate Range trait/struct that's comprised of two KeySelectors, that things like Subspace, Tuple, and, in the future, Directory implement. Rather than RangeOptionBuilder accepting any Encode, perhaps it accepts only Range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant