Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wouldn't make sense for the *spacings to be GridMetricOperations? #3970

Open
simone-silvestri opened this issue Dec 3, 2024 · 5 comments
Open

Comments

@simone-silvestri
Copy link
Collaborator

At the moment they are KernelFunctionOperations. However, we have the GridMetricOperation type which would be very well suited for an AbstractOperation describing grid spacings.

@glwagner
Copy link
Member

glwagner commented Dec 3, 2024

The difference is that GridMetricOperations only have a function when they are used in AbstractOperations like BinaryOperation. But the *spacings can be used stand-alone; for example to plot the grid spacings.

@glwagner
Copy link
Member

glwagner commented Dec 3, 2024

The GridMetricOperations may be redundant or unnecessary now that the spacings are KernelFunctionOperation. So I would go the other direction and consider eliminating GridMetricOperations.

@glwagner
Copy link
Member

glwagner commented Dec 3, 2024

I guess the reaosn to keep them around for now is that we don't have areas or volumes, so we still need GridMetricOperation to form abstract operations with areas and volumes.

@simone-silvestri
Copy link
Collaborator Author

we could write areas and volume functions and eliminate GridMetricOperation

@glwagner
Copy link
Member

glwagner commented Dec 3, 2024

I think ultimately that is the best course of action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants