Should this be called update_boundary_conditions!?

[glwagner]

We were reading the code and explaining it with @odunbar and ran into this... I think that multiple boundary conditions can be updated, is that right @jagoosw?

Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl

Line 39 in 2c955da

@apply_regionally update_boundary_condition!(fields(model), model)

[jagoosw]

Yeah:

Oceananigans.jl/src/BoundaryConditions/update_boundary_conditions.jl

Lines 18 to 27 in 2c955da

	function update_boundary_condition!(fields::Tuple, model)
	N = length(fields)
	ntuple(Val(N)) do n
	field = fields[n]
	bcs = boundary_conditions(field)
	update_boundary_condition!(bcs, field, model)
	end
	return nothing
	end

and

Oceananigans.jl/src/BoundaryConditions/update_boundary_conditions.jl

Lines 5 to 14 in 2c955da

	function update_boundary_condition!(bcs::FieldBoundaryConditions, field, model)
	update_boundary_condition!(bcs.west, Val(:west), field, model)
	update_boundary_condition!(bcs.east, Val(:east), field, model)
	update_boundary_condition!(bcs.south, Val(:south), field, model)
	update_boundary_condition!(bcs.north, Val(:north), field, model)
	update_boundary_condition!(bcs.bottom, Val(:bottom), field, model)
	update_boundary_condition!(bcs.top, Val(:top), field, model)
	update_boundary_condition!(bcs.immersed, Val(:immersed), field, model)
	return nothing
	end

do you think there should be two functions update_boundary_conditions! and update_boundary_condition!, or just the former? I guess its consistent with the rest of the API to have two different ones (e.g. fill_halo_regions! uses fill_X_halo! etc.).

[glwagner]

The main question is: what is easier to understand when reading it?