Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE] Use "m_c" instead "the leader" in leader death messages #3372

Open
rustykitty opened this issue Jan 22, 2025 · 4 comments
Open

[CODE] Use "m_c" instead "the leader" in leader death messages #3372

rustykitty opened this issue Jan 22, 2025 · 4 comments
Labels
enhancement New features or Change to Existing Features

Comments

@rustykitty
Copy link
Contributor

Description
Presently, when a leader dies, the death message looks something like this (gen_death_age_anylead5):

Image

Both "the leader" and "the deputy" cause problems with the clarity and the flow of this sentence, but "the leader" causes a more severe flow issue. For example, "m_c ... The leader" is redundant as a leader's name already has the suffix "star".

@rustykitty rustykitty added the enhancement New features or Change to Existing Features label Jan 22, 2025
@rustykitty
Copy link
Contributor Author

oops, probably should be in #1818

@scribblecrumb
Copy link
Collaborator

iirc I set it up as such so that it would operate smoothly in conjunction with mass death events (where a group of cats is killed) and double death events (where both r_c and m_c are killed). I don't recall how it's appended onto the event and when the text adjustment happens, but the worry would have been a lack of control over who m_c is. If the leader is r_c and dies, then using m_c in the life loss message would give the wrong name. Same for mass death events, where any of the included cats could be m_c. Doesn't mean it can't be changed, but that issue should be kept in mind.

@rustykitty
Copy link
Contributor Author

If the leader is r_c and dies, then using m_c in the life loss message would give the wrong name.

I'm aware; I couldn't think of a good title for the issue referring to the pronoun system though.

@rustykitty
Copy link
Contributor Author

Also, considering how "the leader has %{count} lives left" is concatenated onto the rest of the event text, we could concatenate the lives left string (with leader name parsed) onto the event death text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or Change to Existing Features
Projects
None yet
Development

No branches or pull requests

2 participants