You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove neo-scan from the hot path of make start. This would mean that make start would only set up the basic nodes and start up neo-scan in the background. This change would result in the following difference in output:
Currently:
Starting Docker containers...
Waiting for network.......
After the change:
Starting Docker containers...
Waiting for network.......
Network running! 🎉
neo-scan has been started up but is not currently available, once it has finished booting up we will notify you
(later) "neo-scan is up 🎉"
Why?
According to #4, neo-scan's startup time is significantly slowing down neo-local's start up. Therefore, by removing neo-scan from the hot path of neo-local, we could decrease its booting up time significantly without impacting the workflow, as any system which requires neo-scan could just wait for it to be available (we could also add a flag to put neo-scan back in the hot path to facilitate operation for these systems).
If that sounds like something that you would like added I can implement it myself and submit a PR.
The text was updated successfully, but these errors were encountered:
Describe the Solution
Remove neo-scan from the hot path of
make start
. This would mean thatmake start
would only set up the basic nodes and start up neo-scan in the background. This change would result in the following difference in output:Currently:
After the change:
Why?
According to #4, neo-scan's startup time is significantly slowing down neo-local's start up. Therefore, by removing neo-scan from the hot path of neo-local, we could decrease its booting up time significantly without impacting the workflow, as any system which requires neo-scan could just wait for it to be available (we could also add a flag to put neo-scan back in the hot path to facilitate operation for these systems).
If that sounds like something that you would like added I can implement it myself and submit a PR.
The text was updated successfully, but these errors were encountered: