Allow installing plugins declaratively #6548
Conversation
|
I have been pushing to get Peertube updated in the NixOS packages repository. Unfortunately it does not build because the program itself references to a plugin (which is outside of the program itself). If this PR would be implemented it would fix that problem and we could get Peertube upgraded from 6.0.4 to 6.3.3 |
|
Hi @synq I'm not sure to understand "it does not build because the program itself references to a plugin" because we don't install plugins on PeerTube installation |
|
@Infinidoge Hi :) What's the status or this PR? |
|
Having burnt myself out over yarn while working on this, I will fully admit that it's kinda dead in the water. Because of yarnpkg/yarn#7870 (5 YEARS. COME ON YARN.), making this work with how PeerTube manages plugins internally is... extremely difficult. (Or well, more specifically, making it behave the way I want it to for the greater goal of making it work with Nix is extremely difficult.) To the best of my memory the fundamentals of the PR work. However, due to not hosting a PeerTube instance myself and having many other things higher in priority, I don't have much drive to keep working on it. |
|
Would |
|
Yes. (And if i remember correctly, the current NixOS module patches PeerTube to use |
|
Thanks, I created an issue: #6836 |
Chocobozzz
added
Status: Blocked ✋
Description
Implements the ability for PeerTube to self-install plugins that are declared upfront in a file, checking the file on startup to install/uninstall/update accordingly. The format for the
declarative_plugins.jsonfile is as such:{ "npm-name-here": { "pluginPath": "path/to/plugin/directory", // OR "version": "yarn.add.compatible-version", "extraArgs": "--extra --arguments --passed --to --yarn", "preInstall": "command run before calling yarn", "postInstall": "command run after calling yarn" } }This design makes it very flexible for different ways of handling installing/uninstaling, with the only thing left out being a way to specify a different command to install a plugin with (such as using
npminstead ofyarn). Since Yarn is the foundation for plugin management internally, I decided to leave that out in this implementation.I am not a seasoned TypeScript developer by any stretch of the imagination, so please let me know wherever the code can be improved.
TODO:
Related issues
Resolves #6428
Has this been tested?