-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle reverted events #22
Comments
@bajtos @juliangruber
To still be aware of any reverted deals (and whether it can be an issue even if we go back 940 epochs to account for block finality) there are two strategies to go about this.
I think for now the key part is to have a mechanism in place that informs us if there ever are any reverted events. Our current assumption is that they should simply never occur due to the finality epoch but we are not validating that assumption. Handling reverted events on a database level would be a bigger engineering effort and I think it only pays off if our assumption about reverted events was wrong and for that to be the case we first need to know how often reverted events occur despite our assumptions. This is why I would go with option number 2 and simply add a telemetry alert through grafana whenever a reverted event occurs. Should this be the case often enough to justify the engineering effort we should take action and handle these reverted deals. Let me know what you think :) |
Events emitted from the builtin actors can be reverted. It is marked by a
reverted
bool field in the response of theRawBuiltInActorEvent
rpc call. For now the reverted events should not happen since we only try to fetch blocks which have been finalized already.It is however not guarenteed that they are reverted. We need to address this behaviour and find a solution to events that were reverted.
See the discussion here.
The text was updated successfully, but these errors were encountered: