New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message does not correctly encode network #91

Open

ansermino opened this issue Dec 10, 2024 · 0 comments

Labels

Type: Bug

Member

ansermino commented Dec 10, 2024 •

edited

Loading

Describe the bug

When creating a message the address is not encoded according to the network.

To reproduce

Go to faucet
Open Network Inspector in the browser developer tools
Request funds from the mainnet faucet to a valid 0x address
Observe MpoolPush JSON RPC call

Log output

(Note t address, despite requesting mainnet funds)

Resulting message on mainnet: https://beryx.io/fil/mainnet/txs/bafy2bzacecf2azdaqtr7cwhtlb66l6llq2t4w3xmst5hwr5xlyc52byhnn3ki?tab=overview

Expected behaviour

Should encode the address based on the network of the faucet

Screenshots

Environment (please complete the following information):

Current deployment: https://forest-explorer.chainsafe.dev/faucet

Other information and links

This is a non-critical issue as the RPC server does not validate the address.

The text was updated successfully, but these errors were encountered:

ansermino added the Type: Bug label

github-project-automation bot moved this to New in Forest Backlog 🌲

github-project-automation bot added this to Forest Backlog 🌲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment