Cesium3DTileBatchTable: getClassificationFragmentShaderCallback not used in code?

[remoe]

What happened?

The method getClassificationFragmentShaderCallback in Cesium3DTileBatchTable is not used?

https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Scene/Cesium3DTileBatchTable.js#L786

Reproduction steps

No response

Sandcastle example

No response

Environment

CesiumJS Version: 1.125

[ggetz]

Hi @remoe, thanks for bringing this to our attention.

@lilleyse or @j9liu, do you happen to know if this was cleanup which was overlooked during the Model refactor?

[lilleyse]

If I remember correctly, the batch table code was kept around for .vtcr loading which we didn't have a chance to address in the Model refactor. So it's possible there are parts of Cesium3DTileBatchTable that are no longer used.

[ggetz]

Thanks @lilleyse! To make sure I understand: This was kept around in order to reference when .vtcr loading is to be refactored to fit with the new Model pipeline, correct?

[lilleyse]

.vctr still uses Cesium3DTileBatchTable so we still need the file, but we could delete any code in there that's no longer used