Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we track redundant chaninfo .unitmapping[ix].bValid on incoming CHANREPSPKHPS packets? #12

Open
cboulay opened this issue Oct 20, 2024 · 0 comments

Comments

@cboulay
Copy link
Contributor

cboulay commented Oct 20, 2024

Based on my notes, the device responds to CHANREPSPKHPS packets by setting the spike hoops, but it also sets the chaninfo .unitmapping[unid].bValid field equal to chaninfo's .spkhoops[unid][0].valid.

Do we need to track this particular field when mirroring the device state in pycbsdk? The device uses this field to determine if it should bother checking if a spike meets hoop criteria. I suppose another client software using pycbsdk might do the same if we don't otherwise mark this field as deprecated or unused.


I think we don't need to worry about properly setting this .bValid field when sending a config packet because the device overwrites the field with the 0th hoop's .valid anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant