Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2Crypto removal #41

Closed
e3rd opened this issue Oct 14, 2024 · 0 comments
Closed

M2Crypto removal #41

e3rd opened this issue Oct 14, 2024 · 0 comments

Comments

@e3rd
Copy link
Member

e3rd commented Oct 14, 2024

M2Crypto is a library we use for SMIME. We've recently migrated to cryptography.

  • the test are failing on the server https://github.com/CZ-NIC/envelope/actions/runs/11329031286/job/31503605563 . However, it's green on my local. Why? :D
  • There are still marks of M2Crypto. Remove it in favour of cryptography.
  • loading M2Crypto was slow (30 ms). Loading cryptography seem faster to me (1 ms). The imports might move to the module start.
  • is swig still needed for M2Crypto or we'll remove it from the readme and setup?

Please fork pull request to the new dev branch, thanks!

adidas-official pushed a commit to adidas-official/envelope that referenced this issue Jan 17, 2025
…CZ-NIC#42)

Refactor envelope.py to support multiple recipient certificates
and to use binary PKCS7 options for encryption

---------

Co-authored-by: G22147 <[email protected]>

Test exotic email addresses for v3.11+

Updated tests - fix

Removed redundant commented lines. Added method to import cryptography
library.

setup extras fix

keep current address parsing behaviour for Python3.12
adidas-official pushed a commit to adidas-official/envelope that referenced this issue Jan 17, 2025
…CZ-NIC#42)

Refactor envelope.py to support multiple recipient certificates
and to use binary PKCS7 options for encryption

---------

Co-authored-by: G22147 <[email protected]>

Test exotic email addresses for v3.11+

Updated tests - fix

Removed redundant commented lines. Added method to import cryptography
library.

setup extras fix

keep current address parsing behaviour for Python3.12
e3rd pushed a commit that referenced this issue Jan 17, 2025
Test exotic email addresses for v3.11+
Added method to import cryptography library.
Keep current address parsing behaviour for Python3.12
Properly encrypt and sign to multiple recipients - will fix #41 (#42)

Refactor envelope.py to support multiple recipient certificates
and to use binary PKCS7 options for encryption

---------
Co-authored-by: G22147 <[email protected]>
Co-authored-by: zfydryn <[email protected]>
@e3rd e3rd closed this as completed in 05d7743 Jan 17, 2025
e3rd pushed a commit that referenced this issue Jan 17, 2025
Test exotic email addresses for v3.11+
Added method to import cryptography library.
Keep current address parsing behaviour for Python3.12
Properly encrypt and sign to multiple recipients - will fix #41 (#42)

Refactor envelope.py to support multiple recipient certificates
and to use binary PKCS7 options for encryption

---------
Co-authored-by: G22147 <[email protected]>
Co-authored-by: zfydryn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant