-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Add tests for qse init command with docker-compose flag #106
base: main
Are you sure you want to change the base?
[WIP] - Add tests for qse init command with docker-compose flag #106
Conversation
…FileList - Mark need database templates tests with skip - express_pg - express_pg_sequelize - express_pg_prisma - express_mongo - express_mysql
@Ashrockzzz2003 , I skipped the template tests that have the Would you find it appropriate to replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afmireski
Thanks for moving the files to ignore while computing sha256 to a list from if. Codebase looks better there now.
About the needDb
flag, yes, you can add a flag.
I see you've removed the code for the user prompt. Instead, comment it out. In future when we find a way to test it, we might need it. Please do comment out that code instead of removing it. Same for the new flag needDb
Overall looks good!
At last please run npm run format
and then check if npm run test:format
exits without an error. We're following standard code formatting across the codebase to ensure they are not highlighted as a change in PRs. This check is part of the CI too!
Also, add yourselves to contributors in README
.
… images will use this resource - Added flag --no-db
…s need db question
Hello, @Ashrockzzz2003. I've made the suggested changes and implemented the I considered mocking either the |
Resolves #98
Description
Tests were implemented to verify the behavior of the --docker-compose flag in the init command.
Based on the discussions in the issue and the challenges faced by @alguiguilo098, I followed the suggestions and introduced a new flag:
--add-cache-service
.Added the --no-db flag to allow bypassing the
needDb
prompt check in templates that had this option enabled.Waiting @Ashrockzzz2003 review.