Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[External] [Feature] Running Variola Sequences through Pipeline #65

Closed
1 task done
jtakakuwa opened this issue Aug 24, 2023 · 0 comments · Fixed by #84
Closed
1 task done

[External] [Feature] Running Variola Sequences through Pipeline #65

jtakakuwa opened this issue Aug 24, 2023 · 0 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request implement

Comments

@jtakakuwa
Copy link

What is the Feature Related To? Please Provide a Description.
The pipeline needs to be adjusted to run variola samples through the annotation and submission process. Portions of the script with mpox-specific parameters need to be adjusted to allow it to run with variola.

Place an ❌ in a Box that Best Matches the Feature's Importance:

  • [] 1 - Most important (absolutely integral and will not use codebase at all without it)
  • 2-4 - Moderate (still using codebase for other functions but is serving as a blocker for future use-cases)
  • [] 5 - Least important (would like to see but there are no stringent expectations nor urgency for current/future use-cases) 

Any Additional Context or Information? Has There Been Any Progress Made So Far Towards this Request? Any Helpful Resources to Reference? Screenshots or Links?

  1. Initial testing with the variola reference genome as a sample as well as a fasta with seven different
    variola samples. Both tests pass the validate parameters, cleanup files and metadata validation steps.
    However, they both fail the liftoff annotation process. This was resolved by changing the FASTA files from ASCII text to ASCII text with very long lines (producing a single-line FASTA, with header and sequence).

Error resolved by 1:
only_liftoff_2
only_liftoff_3

  1. Testing proceeds, the pipeline still fails at the liftoff stage. The variola reference was changed to include repeat_region, CDS and gene information. This resolved the current error but created a different error.

Error resolved by 2:
liftoff_error
liftoff_error2
liftoff_error3

  1. The traceback was used to find that the error was originating in the add_repeat_region_lines function in liftoff_submission.py. This function was commented out, which allowed successful processing of the variola sample.

Error resolved by 3:

Screenshot (10)

In Case for Additional Follow-Up, Please Provide your Email:

@jtakakuwa jtakakuwa added the enhancement New feature or request label Aug 24, 2023
@ankushkgupta2 ankushkgupta2 self-assigned this Aug 24, 2023
@ankushkgupta2 ankushkgupta2 changed the title [External] [Feature] Running variola sequences through the pipeline [External] [Feature] Running Variola Sequences through Pipeline Sep 7, 2023
@ankushkgupta2 ankushkgupta2 pinned this issue Sep 21, 2023
@zyosufzai zyosufzai linked a pull request Nov 17, 2023 that will close this issue
3 tasks
@ankushkgupta2 ankushkgupta2 unpinned this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants