Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View kws set in a base_state are not respected #62

Open
bdpedigo opened this issue Dec 18, 2024 · 1 comment
Open

View kws set in a base_state are not respected #62

bdpedigo opened this issue Dec 18, 2024 · 1 comment

Comments

@bdpedigo
Copy link
Contributor

self._temp_viewer.set_view_options(**self._view_kws)

not sure if this is intentional or not, but if I have anything set in a base_state that is overlapping with the options in set_view_options, they seem to get overridden to nothing because they aren't passed in to the line above

@ceesem
Copy link
Collaborator

ceesem commented Dec 19, 2024

That's a totally reasonable point that wasn't intentional and makes sense with the implementation. In general, I think updating the view_kws configuration is on the table for a major upgrade that would fix this and also just make the process more discoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants