Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of AdvantageKit #145

Open
falOn-Dev opened this issue Dec 21, 2023 · 10 comments
Open

Integration of AdvantageKit #145

falOn-Dev opened this issue Dec 21, 2023 · 10 comments
Labels
wontfix This will not be worked on

Comments

@falOn-Dev
Copy link

I was wondering if there had been any thoughts of integrating advantagekit into YAGSL, I'd even be willing to contribute to it and use my team's bot to test it if necessary.

@Technologyman00
Copy link
Collaborator

I think it's something that would be really cool to incorporate into YAGSL.

I haven't looked into Advantage Kit but I've heard it complicates the robot project. YAGSL sits in a difficult spot. It should be easy to get into and modify but have a high enough ceiling that a more advanced team can get more performance out of it.

@falOn-Dev
Copy link
Author

I still am just looking into it for the first time, but it certainly does complicate a lot of stuff. Although I think it could end up being harder having it set up in a way that doesn't force the team to use advantagekit

@thenetworkgrinch
Copy link
Contributor

That is my conclusion as well, I have talked with the AdvantageKit devs before about it and we have concluded YAGSL is possible to integrate into AdvantageKit however it would require users to call functions synchronously with periodic's and modify the SwerveTelemtry too. I dont think its worth adding bc i want YAGSL to remain first and foremost, a library NOT a template.

@falOn-Dev
Copy link
Author

If you don't mind then, I may fork YAGSL and mess with implementing it myself

@thenetworkgrinch
Copy link
Contributor

thenetworkgrinch commented Dec 22, 2023

Go ahead, and Good luck! Its a pain maintaining a fork though but itd be a good reference for teams.

@falOn-Dev falOn-Dev closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
@falOn-Dev
Copy link
Author

I'd like to reopen this issue now that AdvantageScope is an official WPILIB Tool. I feel like it should be pretty basic to implement just a basic SwerveDriveIO Class, since a lot of abstraction is already done for motors and the like

@falOn-Dev falOn-Dev reopened this Jan 19, 2024
@thenetworkgrinch
Copy link
Contributor

AdvantageScope != AdvantageKit however it is a consideration I still do not want the user to have to do anything other than include the library.

@thenetworkgrinch thenetworkgrinch transferred this issue from BroncBotz3481/YAGSL Jan 22, 2024
@thenetworkgrinch thenetworkgrinch added the wontfix This will not be worked on label Jan 26, 2024
@thenetworkgrinch
Copy link
Contributor

This is being worked on as a PR, not by us. The PR has an idea and will be reviewed and merged provided advantagekit-less projects still function

@toddas90
Copy link

Which PR is this? I didn't see it in the list, but I may have just missed it. I'd love to take a look.

@thenetworkgrinch
Copy link
Contributor

It was being made by @falOn-Dev but i think it has been dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants