You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the Newtonsoft.Json dependency by migrating usages to System.Text.Json.
At a quick glance, changes would be to BranchContentMetadata.cs, BranchEvent.cs, BranchLinkProperties.cs, BranchUniversalObject.cs, BranchiOSUtils.cs.
Usages of JsonConvert.DeserializeObject<Dictionary<string,object>> would become JsonSerializer.Deserialize<Dictionary<string, JsonElement>> and subsequent code for plucking out properties would be updated appropriately.
Usages of JsonConvert.SerializeObject would be replaced with JsonSerializer.Serialize. Need to verify that default serialization settings match or configure STJ options to match (so that ToJsonString methods still return the same output), or it could be a breaking change.
If maintainers are open to the change I could take a crack at this.
The text was updated successfully, but these errors were encountered:
Describe the feature
Remove the Newtonsoft.Json dependency by migrating usages to System.Text.Json.
At a quick glance, changes would be to
BranchContentMetadata.cs
,BranchEvent.cs
,BranchLinkProperties.cs
,BranchUniversalObject.cs
,BranchiOSUtils.cs
.Usages of
JsonConvert.DeserializeObject<Dictionary<string,object>>
would becomeJsonSerializer.Deserialize<Dictionary<string, JsonElement>>
and subsequent code for plucking out properties would be updated appropriately.Usages of
JsonConvert.SerializeObject
would be replaced withJsonSerializer.Serialize
. Need to verify that default serialization settings match or configure STJ options to match (so thatToJsonString
methods still return the same output), or it could be a breaking change.If maintainers are open to the change I could take a crack at this.
The text was updated successfully, but these errors were encountered: