Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metadata from middleware #9

Open
StoneFrog opened this issue Feb 1, 2022 · 0 comments
Open

Support metadata from middleware #9

StoneFrog opened this issue Feb 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@StoneFrog
Copy link
Collaborator

Currently, we store job args, class_name etc. coming by default with sidekiq.
In some cases, we may want to use additional middleware to pass over, for example, correlation_id or causation_id. While this will work in regular flow, we will lose it in case there is some crash and the job is removed from Redis. In such case, MissedJobsScheduler, will execute those jobs fine, yet without middleware data.

The idea would be to persist context from custom middleware either as a config with keys to store, or convention (eg. make middlewares add all metadata under given key and make robust gem use it)

@StoneFrog StoneFrog added the enhancement New feature or request label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant