Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include of <boost/serialize> #893

Closed
1uc opened this issue Dec 13, 2023 · 2 comments
Closed

Remove include of <boost/serialize> #893

1uc opened this issue Dec 13, 2023 · 2 comments
Labels
v3 Anything that needs to be resolved before `v3`.

Comments

@1uc
Copy link
Collaborator

1uc commented Dec 13, 2023

We should remove this include:

HighFive/include/highfive/bits/H5Inspector_misc.hpp

Lines 26 to 28 in c660174

// starting Boost 1.64, serialization header must come before ublas
#include <boost/serialization/vector.hpp>
#include <boost/numeric/ublas/matrix.hpp>

HighFive doesn't require serialize and shouldn't force the dependency on its users.
@matz-e
Copy link
Member

matz-e commented Dec 14, 2023

I concur.

@1uc 1uc added v3 Anything that needs to be resolved before `v3`. ready labels Dec 14, 2023
@1uc
Copy link
Collaborator Author

1uc commented Feb 12, 2024

Merged: #903

@1uc 1uc closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3 Anything that needs to be resolved before `v3`.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matz-e @1uc