Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CI to avoid nameclashes. #720

Open
1uc opened this issue Apr 3, 2023 · 1 comment
Open

Investigate CI to avoid nameclashes. #720

1uc opened this issue Apr 3, 2023 · 1 comment
Labels
testing Anything related to (automated) tests.

Comments

@1uc
Copy link
Collaborator

1uc commented Apr 3, 2023

Since we recently had an issue where we allowed names reserved for macros to be used in HighFive, e.g. DEBUG or INFO, it would make sense to investigate if there's any static analysis we can set up, e.g. clang-tidy to ban UPPERCASE names for anything that isn't a macro.

See #716 for the type of issue we want to detect.
@1uc 1uc changed the title Investigate CI for avoid nameclashes. Investigate CI to avoid nameclashes. Apr 4, 2023
@1uc
Copy link
Collaborator Author

1uc commented Apr 4, 2023

There's this:
https://clang.llvm.org/extra/clang-tidy/checks/readability/identifier-naming.html

@1uc 1uc added the testing Anything related to (automated) tests. label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Anything related to (automated) tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc