Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DAL) Improve Cleanup Logic in Hub #2135

Closed
coderabbitai bot opened this issue Aug 17, 2024 · 1 comment
Closed

(DAL) Improve Cleanup Logic in Hub #2135

coderabbitai bot opened this issue Aug 17, 2024 · 1 comment
Assignees
@nick-bisonai

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 17, 2024

The cleanup method in the Hub struct iterates over clients to remove those with no subscriptions. Consider using a more efficient data structure or algorithm to improve performance. This enhancement will be considered in a future pull request.

For more details, see the PR: #2133
Comment URL: #2133 (comment)
@nick-bisonai
Copy link
Collaborator

I don't think this is necessary in current scale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick-bisonai nick-bisonai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nick-bisonai