You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The permalink copied to clipboard does not take into account the hash fragment of the URL. This fragment i not sent to the server by clients, so it has to be managed in js. It's important notably for TopAnat, without the hash, the permalink is useless.
Also, fix tests in RequestParametersTest using TEST_STABLE_ROOT_DIR, there's a problem when we need to manage the hash part with the method getStableRequestURL. Maybe this highlights a wider design issue with the method signatures in RequestParameters class.
The text was updated successfully, but these errors were encountered:
In GitLab by @fbastian on Feb 13, 2019, 17:51
The permalink copied to clipboard does not take into account the hash fragment of the URL. This fragment i not sent to the server by clients, so it has to be managed in js. It's important notably for TopAnat, without the hash, the permalink is useless.
Also, fix tests in
RequestParametersTest
usingTEST_STABLE_ROOT_DIR
, there's a problem when we need to manage the hash part with the methodgetStableRequestURL
. Maybe this highlights a wider design issue with the method signatures inRequestParameters
class.The text was updated successfully, but these errors were encountered: