Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack-In when mutliple projects are in the workspace #273

Closed
kstehn opened this issue Aug 5, 2019 · 2 comments
Closed

Jack-In when mutliple projects are in the workspace #273

kstehn opened this issue Aug 5, 2019 · 2 comments

Comments

@kstehn
Copy link
Contributor

kstehn commented Aug 5, 2019

When i have multiple projects in my workspace and want to jack-in, it always picks the first project folder it finds with the project.clj file.

With the config: Project Root Directory it also doesn't work.

For example:
Workspace:

  • foo
  • bar

I want to jack-in in bar open one clojure-file in bar and try to jack-in.
Result: jack-in processs starts in foo

When i change the Project Root Directory to bar/ it also jacks-in to foo.

Also i think its not really helpfull when you always need to change the config when you want to jack-in another project.

I guess the solution should be somewhere in the connect, because with the connect it always finds the right directory.

@PEZ
Copy link
Collaborator

PEZ commented Aug 5, 2019

I think the logic in getProjectDir() is faulty. And also it might need to be adapted to more specifically support this. More like the way we find the nrepl-port file. Start from the active editor file and search for project files from there and upwards. Maybe we can even remove the settings for this if we do it right.

@kstehn
Copy link
Contributor Author

kstehn commented Aug 12, 2019

Resolved with the merge #275

@kstehn kstehn closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants