-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need the ability to be able to state which css file a template, partial, or module should go in #64
Comments
Might be tricky but maybe you could control what file it compiles into, so you'd end up having multiple assemble scss files. Like now it compiles Maybe with the modifier mentioned above, it could compile These files would have to be manually added to new SCSS master files. Thoughts? |
So just to make sure I'm understanding your idea: All Or do you also want the ability to make a module or partial opt out of the Either way, I think we could totally do that. I think the best way to do it would be to set a sort of data attribute on the <div class="example-module" data-css-compile="<something>">
{{! awesome module stuff }}
</div> I could tweak the the The data attribute could even be an array of files (passed as string then So lets say you (for some odd reason) have need of:
You could set the attribute as You then could omit a file from being added to Thoughts? |
I'm a bit iffy about having crazy kooky data attributes on the modules because I don't want crap like that getting into integration. So unless we added something that stripped those out on compile, I think we should do something else. |
Eh, I'm a fan of data attributes for setting things. But I think we could set it in the yaml at the top. I'd have to look into its syntax. Another option would be to create a sort of config file where we could define alternate css builds. |
Setting things is fine, but these attributes wouldn't be used by CSS or JavaScript in the final site, so I don't want them there. It just adds confusion to whoever integrates the site. |
We need the ability to be able to state which css file a template, partial, or module should go in and will need to be able to change it later on in the project. Perhaps it could be set along with the other configuration options in the .hbs file.
title: "accordion"
layout: module.hbs
css: level
module: true
The text was updated successfully, but these errors were encountered: