Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Selection inconsistency when table structure changes #26

Open
BUZZARDGTA opened this issue Jan 9, 2025 · 3 comments
Open

Bug: Selection inconsistency when table structure changes #26

BUZZARDGTA opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@BUZZARDGTA
Copy link
Owner

BUZZARDGTA commented Jan 9, 2025

Description:
When selecting cells in the table, if a row or column is added or removed nearby, the selection remains tied to the previous data instead of adjusting to reflect the updated table structure.

This leads to an inconsistent user experience, as the selected cells no longer represent the intended data.

Steps to Reproduce 1:

  • Select a cell from one of the connected or disconnected tables.
  • Wait for a player to add or remove a row or column near the selected cells.
  • Observe that the selection remains tied to the previous positions instead of updating to match the new table layout.

Expected Behavior 1:
The selection should dynamically adjust to reflect the updated table structure, ensuring that the intended data remains selected.

Steps to Reproduce 2:

  • Select the cell from a player connected.
  • Wait for that player to disconnect.
  • Observe that the selection remains tied to a new player from this same position.

Expected Behavior 2:
The selection should deselect this position, ensuring that the intended data remains unselected, or select the newly disconnected player at same position.

@BUZZARDGTA
Copy link
Owner Author

I currently have no plans to fix this issue, as I’m unsure how to address the bug or implement a solution.

@BUZZARDGTA BUZZARDGTA pinned this issue Jan 9, 2025
@BUZZARDGTA BUZZARDGTA added the bug Something isn't working label Jan 9, 2025
@BUZZARDGTA BUZZARDGTA self-assigned this Jan 9, 2025
@BUZZARDGTA BUZZARDGTA reopened this Jan 20, 2025
@BUZZARDGTA
Copy link
Owner Author

BUZZARDGTA commented Jan 20, 2025

Reopening because there's still an issue: when a player is removed from the connected table and added to the disconnected table, the selections in the disconnected table are not updated accordingly.

@BUZZARDGTA
Copy link
Owner Author

It’s likely the same issue with the connected table: if a player is added to the top of the table, the selections are shifted inconsistently.
Honnestly this part of the selection code is fucked up, I think I'll completely drop the algorythm implemented in this commit and instead add a memory for selections, when refreshing the gui it will select back if not selected each selections based on the IP address section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant