Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] ci: Avoid running workflow when not needed #32

Open
blanquicet opened this issue Apr 26, 2023 · 2 comments
Open

[RFE] ci: Avoid running workflow when not needed #32

blanquicet opened this issue Apr 26, 2023 · 2 comments
Labels
ci Continuous Integration good first issue Good for newcomers

Comments

@blanquicet
Copy link
Member

For instance, PR #27 only updated README and the krew manifest. In that case, workflow doesn't need to run. Same if only files under docs are modified, etc.

@blanquicet blanquicet added good first issue Good for newcomers ci Continuous Integration labels Apr 26, 2023
@mqasimsarfraz
Copy link
Member

One possible implementation can be to use paths filter to trigger the CI e.g:

on:
  pull_request:
    paths:
      - '**.yml'
      - '**.go'
      - 'go.mod'
      - 'go.sum'
  push:
    branches:
      - main
    tags:
      - 'v*'

Or may be we are allowed to exclude paths using paths as well?

@blanquicet
Copy link
Member Author

I would also include Makefile and yaml (we have config.yaml but exclude .krew.yaml).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants