Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Check of API server connectivity for all the nodes on one single call #3

Open
blanquicet opened this issue Feb 16, 2022 · 2 comments
Labels
check-apiserver-connectivity Command check-apiserver-connectivity enhancement New feature or request
Milestone

Comments

@blanquicet
Copy link
Member

blanquicet commented Feb 16, 2022

Current situation

Currently, the check-apiserver-connectivity command requests users to specify the node where the check will be performed:

$ kubectl get nodes
NAME                                STATUS   ROLES   AGE   VERSION
aks-agentpool-27170680-vmss000000   Ready    agent   11d   v1.22.4
aks-agentpool-27170680-vmss000001   Ready    agent   11d   v1.22.4
aks-agentpool-27170680-vmss000002   Ready    agent   11d   v1.22.4

$ kubectl aks check-apiserver-connectivity --node aks-agentpool-27170680-vmss000000
Running...

Connectivity check: succeeded

Impact

Users needs to execute kubectl-aks multiple times to check the connectivity of all the nodes.

Ideal future situation

The check-apiserver-connectivity should allow user to request this check over all the nodes on one single call:

Example:

$ kubectl aks check-apiserver-connectivity [--all-nodes]
Running...

Connectivity check on "aks-agentpool-27170680-vmss000000": succeeded
Connectivity check on "aks-agentpool-27170680-vmss000001": succeeded
Connectivity check on "aks-agentpool-27170680-vmss000002": succeeded

Implementation options

  • Please verify this discussion before proceeding with the implementation.
  • Try to perform all the checks in parallel.
@blanquicet blanquicet added enhancement New feature or request check-apiserver-connectivity Command check-apiserver-connectivity labels Feb 16, 2022
@blanquicet blanquicet changed the title Check of API server connectivity for all the nodes on one single call [RFE] Check of API server connectivity for all the nodes on one single call Feb 16, 2022
@blanquicet blanquicet added this to the v0.1.1 milestone Apr 5, 2023
@mqasimsarfraz mqasimsarfraz modified the milestones: v0.2.1, v0.3.0 May 30, 2023
@mqasimsarfraz
Copy link
Member

mqasimsarfraz commented Jul 11, 2023

Now that we have the config file with mapping kubernetes node names -> VMSS instance information I am thinking we should just loop over the nodes from the config and run the connectivity checks? Perphas --all flag or something. What do you think? @blanquicet

@blanquicet
Copy link
Member Author

Now that we have the config file with mapping kubernetes node names -> VMSS instance information I am thinking we should just loop over the nodes from the config and run the connectivity checks? Perphas --all flag or something. What do you think? @blanquicet

Agree. By default, it would use the node from config use-node or --node, as run-command does. And then, --all-nodes or simply --all to do the same for all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-apiserver-connectivity Command check-apiserver-connectivity enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants