Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: bake fails when Helm Chart source file contains leading (SPDX copyright header) comments #117

Open
1 task done
edgarvonk opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@edgarvonk
Copy link

What happened?

We want our Helm Chart source files to start with SPDX Copyright header files like:

#
# SPDX-FileCopyrightText: 2024 XXX
# SPDX-License-Identifier: EUPL-1.2+
#

apiVersion: v1
kind: ServiceAccount
[..]

However when we add these to our files the azure/k8s-bake@v3 fails to bake the Helm Chart because it incorrectly prepends the first line after the comments with a # like so:

# Source: templates/serviceaccount.yaml
#
# SPDX-FileCopyrightText: 2024 XXX
# SPDX-License-Identifier: EUPL-1.2+
#apiVersion: v1
kind: ServiceAccount

This seems a bug to me because comments in Helm Chart yaml files are quite normal and should be supported I think?

Version

  • I am using the latest version

Runner

ubuntu-latest

Relevant log output

---
# Source: zaakafhandelcomponent/templates/serviceaccount.yaml
#
# SPDX-FileCopyrightText: 2022 Atos, 2024 Lifely
# SPDX-License-Identifier: EUPL-1.2+
#apiVersion: v1
kind: ServiceAccount
@edgarvonk edgarvonk added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant