Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can specify whether to create a new namespace with Helm template #446

Open
nwnt opened this issue Dec 13, 2024 · 1 comment
Open

Comments

@nwnt
Copy link

nwnt commented Dec 13, 2024

Is your feature request related to a problem? Please describe.
We're working on integrating Fleet manager with Automated Deployment (#426). The role we are targeting to assign onto the integrating app is Fleet RBAC Writer. However, helm upgrade -i command in the draft generated template always creates a namespace, which can't be achieved by the role we want to assign to Fleet as a namespace is a cluster scoped resource. We do not want to just change the role to Cluster Writer yet. This is because in Fleet Manager we want to differentiate 2 personas: one for cluster admin app that can create cluster scoped objects; another for application team app that can create ns scoped objects like deployments.

Can we propose that we introduce a new parameter that will make --create-namespace- flag in the current helm command run optional? If so we can start working on a PR.

Mention what platform you want to support the new feature
Existing platform.

Describe the solution you'd like
Can we propose that we introduce a new parameter that will make --create-namespace- flag in the current helm command run optional? If so we can start working on a PR.

Describe alternatives you've considered
Using a cluster writer role, but we don't want to assume that the same app will do both application deployment and cluster management tasks.

@davidgamero
Copy link
Collaborator

yes adding a createnamespace variable that defaults to true would be in line with the current workflow templates

you can set that to false when selecting fleet clusters

we should enable this across all deploy types (helm, kustomize, manifests) to present a uniform experience

@davidgamero davidgamero reopened this Dec 13, 2024
@nwnt nwnt mentioned this issue Dec 16, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants