-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore using Azure.Core for KeyVaultSetting #32174
Comments
@heaths Is this something we still want to explore for GA given we are mostly code-complete? |
That's more of a question for @KrzysztofCwalina and @tg-msft. Are we ready to push |
I would love to move it to Azure.Core, but we cannot just push it. We need to: a) identify scenarios we need to support, b) validate that it works in scenarios we want it to work, c) go through arch review. |
Do we have a tracking issue to evaluate Azure.Value for Azure.Core? |
I don't see anything currently. @KrzysztofCwalina is there anything tracking release of |
I don't think we have anything. |
Tracking in #32978. I optimistically added it to the 2023-01 milestone. Feel free to update pragmatically. |
|
Currently, we plan to ship
KeyVaultSetting
as an immutable type so that we can better control what values we accept as input (output/response is open) since we need to set the type. For GA, we should explore usingAzure.Value
(source) which is basically like a COMVARIANT
.If we did that, we could make
KeyVaultSetting
mutable but need to make sure that the user doesn't change theValue
type. Ultimately, it won't much matter since the service won't allow changing the type anyway. Also, the typed stored has to be serializable as a string.The text was updated successfully, but these errors were encountered: