Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using Azure.Core for KeyVaultSetting #32174

Closed
heaths opened this issue Oct 28, 2022 · 8 comments
Closed

Explore using Azure.Core for KeyVaultSetting #32174

heaths opened this issue Oct 28, 2022 · 8 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented Oct 28, 2022

Currently, we plan to ship KeyVaultSetting as an immutable type so that we can better control what values we accept as input (output/response is open) since we need to set the type. For GA, we should explore using Azure.Value (source) which is basically like a COM VARIANT.

If we did that, we could make KeyVaultSetting mutable but need to make sure that the user doesn't change the Value type. Ultimately, it won't much matter since the service won't allow changing the type anyway. Also, the typed stored has to be serializable as a string.

@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 28, 2022
@heaths heaths added this to the 2023-01 milestone Oct 28, 2022
@heaths heaths self-assigned this Oct 28, 2022
@pallavit
Copy link
Contributor

pallavit commented Dec 7, 2022

@heaths Is this something we still want to explore for GA given we are mostly code-complete?

@heaths
Copy link
Member Author

heaths commented Dec 7, 2022

That's more of a question for @KrzysztofCwalina and @tg-msft. Are we ready to push Azure.Value to Azure.Core GA?

@KrzysztofCwalina
Copy link
Member

I would love to move it to Azure.Core, but we cannot just push it. We need to: a) identify scenarios we need to support, b) validate that it works in scenarios we want it to work, c) go through arch review.

@pallavit
Copy link
Contributor

pallavit commented Dec 7, 2022

Do we have a tracking issue to evaluate Azure.Value for Azure.Core?

@heaths
Copy link
Member Author

heaths commented Dec 7, 2022

I don't see anything currently. @KrzysztofCwalina is there anything tracking release of Azure.Value?

@KrzysztofCwalina
Copy link
Member

I don't think we have anything.

@heaths
Copy link
Member Author

heaths commented Dec 8, 2022

Tracking in #32978. I optimistically added it to the 2023-01 milestone. Feel free to update pragmatically.

@jsquire jsquire modified the milestones: 2023-01, Backlog Jan 19, 2023
@heaths
Copy link
Member Author

heaths commented Jul 20, 2023

KeyVaultSetting GA'd, so this is no longer relevant.

@heaths heaths closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Archived in project
Development

No branches or pull requests

4 participants