Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Service bus custom endpoint address #43555

Closed
Anton0123 opened this issue Dec 23, 2024 · 5 comments · Fixed by #43706
Closed

[BUG] Service bus custom endpoint address #43555

Anton0123 opened this issue Dec 23, 2024 · 5 comments · Fixed by #43706
Assignees
@moarychan
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone
2025-02

Comments

@Anton0123
Copy link

Anton0123 commented Dec 23, 2024 •
edited
Loading

Describe the bug
The custom endpoint address is not merged from the namespace properties to producer/processor/consumer properties. This results in the custom endpoint address being null.

To Reproduce
Configure a custom endpoint address for the namespace but not for individual consumers or producers. The custom endpoint address will not be used when sending or receiving messages.

Code Snippet
Example configuration

spring:
  cloud:
    function:
      definition: consume;supply
    stream:
      bindings:
        consume-in-0:
          destination: sbq-test-1
        supply-out-0:
          destination: sbq-test-2
      binders:
        servicebus-0:
          type: servicebus
          default-candidate: true
          environment:
            spring:
              cloud:
                azure:
                  client:
                    amqp:
                      transport-type: amqp_web_sockets
                  servicebus:
                    custom-endpoint-address: https://test.address.com:443
                    namespace: sb-test-1
                    credential:
                      client-id: ${CLIENT_ID}
                      client-secret: ${CLIENT_SECRET}
                    profile:
                      tenant-id: ${TENANT_ID}
      servicebus:
        bindings:
          consume-in-0:
            consumer:
              entity-type: queue
          supply-out-0:
            producer:
              entity-type: queue

Expected behavior
I expect the custom-endpoint-address to be used by the consumers/producers/processors.

Screenshots
Image

Setup (please complete the following information):

  • OS: Windows 11
  • IDE: IntelliJ
  • Library/Libraries: com.azure.spring:spring-cloud-azure-stream-binder-servicebus:5.19.0
  • Java version: 22
  • App Server/Environment: -
  • Frameworks: Spring boot

Additional context
See com.azure.spring.messaging.servicebus.implementation.properties.merger, for example SenderPropertiesParentMerger. It does not map the custom endpoint address.
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/spring-messaging-azure-servicebus/src/main/java/com/azure/spring/messaging/servicebus/implementation/properties/merger/SenderPropertiesParentMerger.java
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 23, 2024
@jairmyree jairmyree added the azure-spring All azure-spring related issues label Dec 31, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 31, 2024
@jairmyree
Copy link
Member

@Anton0123 Thank you for reaching out. @Netyyyy could you please look into this issue?

@Netyyyy
Copy link
Member

Netyyyy commented Jan 3, 2025

Sure, we will take a look

@Anton0123
Copy link
Author

Sure, we will take a look

Thank you, this is currently a blocker for us going into production

@saragluna saragluna added this to the 2025-02 milestone Jan 6, 2025
@saragluna saragluna added the azure-spring-servicebus Spring service bus related issues. label Jan 6, 2025
@moarychan
Copy link
Member

HI @Anton0123 , thanks for using Spring Cloud Azure!

You can use the below workaround first; the fix is coming and available in the next version:

Add below Java configuration:

@Configuration
class ServiceBusClientConfiguration {

    @Bean
    AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder> reproducerCustomizer() {
        return builder -> builder.customEndpointAddress("https://test.address.com:443");
    }

    @Bean
    ServiceBusProcessorFactoryCustomizer processorFactoryCustomizer(@Qualifier(DEFAULT_TOKEN_CREDENTIAL_BEAN_NAME) TokenCredential defaultAzureCredential,
                                                                    AzureTokenCredentialResolver azureTokenCredentialResolver,
                                                                    ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder>> clientBuilderCustomizers) {
        return (processor -> {
            if (processor instanceof DefaultServiceBusNamespaceProcessorFactory factory) {
                factory.setDefaultCredential(defaultAzureCredential);
                factory.setTokenCredentialResolver(azureTokenCredentialResolver);
                clientBuilderCustomizers.orderedStream().forEach(factory::addServiceBusClientBuilderCustomizer);
            }
        });
    }

    @Bean
    ServiceBusProducerFactoryCustomizer producerFactoryCustomizer(@Qualifier(DEFAULT_TOKEN_CREDENTIAL_BEAN_NAME) TokenCredential defaultAzureCredential,
                                                                  AzureTokenCredentialResolver azureTokenCredentialResolver,
                                                                  ObjectProvider<AzureServiceClientBuilderCustomizer<ServiceBusClientBuilder>> clientBuilderCustomizers) {
        return (producer -> {
            if (producer instanceof DefaultServiceBusNamespaceProducerFactory factory) {
                factory.setDefaultCredential(defaultAzureCredential);
                factory.setTokenCredentialResolver(azureTokenCredentialResolver);
                clientBuilderCustomizers.orderedStream().forEach(factory::addServiceBusClientBuilderCustomizer);
            }
        });
    }
}

@moarychan moarychan mentioned this issue Jan 6, 2025
Merged
6 tasks
@Anton0123
Copy link
Author

@moarychan Thank you for the quick resolution and for the workaround! It seems like it did the trick.

@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moarychan moarychan

Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Spring Cloud Azure
Status: Done
Milestone
2025-02
5 participants
@Anton0123 @moarychan @saragluna @jairmyree @Netyyyy