Fix Change Feed Full Fidelity Tests #43483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosRowConverterBase.scala
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
approved these changes
Jan 8, 2025
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to tvaron3/fixFFChangeFeedEmulatorTests
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default experience for full fidelity change feed changed to not expose previous image for deletes. Later, there will be an option for customers to enable this as well as enable previous image for deletes, but it's not there yet. Existing customers continue to get previous image for deletes- change is only to default for new accounts. Changed the tests to expect the new default behavior and added null checking in spark connector in this scenario.
Emulator configs for previous behavior
Override for behavior of pre-existing FFCF accounts with prev image for deletes: enablePreviousImageForDeleteInFFCF