Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VirtualRouterAutoScaleConfiguration for Route Server #30614

Open
ksteinmeyer2023 opened this issue Jan 6, 2025 · 1 comment
Open

Adding VirtualRouterAutoScaleConfiguration for Route Server #30614

ksteinmeyer2023 opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@ksteinmeyer2023
Copy link

1. Resource provider. What is the Azure resource provider your feature is part of?

Microsoft.Network

2. Description of feature or work requested. Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too.

Add the VirtualRouterAutoScaleConfiguration to the route server object. Users should be able to create, update, and see the VirtualRouterAutoScaleConfiguration on the route server.

The following CLI cmdlets will need to be updated and tested with these changes:
az network routeserver create
az network routeserver update
az network routeserver show
az network routeserver list

3. Minimum API version required. What is the minimum API version of your service required to implement your feature?

2021-06-01

4. Swagger link. Provide a link to the location of your feature(s) in the REST API specs repo. If your feature(s) has corresponding commit or pull request in the REST API specs repo, provide them. This should be on the master branch of the REST API specs repo.

The virtualRouterAutoScaleConfiguration property is defined on the VirtualHubs object, to create a route server a user would then need to create an ipConfigurations object referencing the virtualHubs object. Both definitions are contained within the linked file below:

https://github.com/Azure/azure-rest-api-specs/blob/33e96cb2d622465600fc4d49002f8a6e9370e738/specification/network/resource-manager/Microsoft.Network/stable/2024-05-01/virtualWan.json

Virtual hub PUT example:
https://github.com/Azure/azure-rest-api-specs/blob/33e96cb2d622465600fc4d49002f8a6e9370e738/specification/network/resource-manager/Microsoft.Network/stable/2024-05-01/examples/VirtualHubPut.json

Ip Configuration PUT example:
https://github.com/Azure/azure-rest-api-specs/blob/33e96cb2d622465600fc4d49002f8a6e9370e738/specification/network/resource-manager/Microsoft.Network/stable/2024-05-01/examples/VirtualHubIpConfigurationPut.json

5. Target date. If you have a target date for releasing this feature/work, please provide it. While we can't guarantee these dates, it will help us prioritize your request against other requests.

The target for releasing the feature is 3/15/2024.

6. Where do you want the feature to locate? A command module or an extension? Here is a Comparison.

Within a command module

7. Status of the service. Is it in preview or GA?

The service is GA

8. Examples of the feature. Usually REST API specs repo should contain examples. An independent documentation or tutorial is also OK.

Virtual hub PUT example:
https://github.com/Azure/azure-rest-api-specs/blob/33e96cb2d622465600fc4d49002f8a6e9370e738/specification/network/resource-manager/Microsoft.Network/stable/2024-05-01/examples/VirtualHubPut.json

Ip Configuration PUT example:
https://github.com/Azure/azure-rest-api-specs/blob/33e96cb2d622465600fc4d49002f8a6e9370e738/specification/network/resource-manager/Microsoft.Network/stable/2024-05-01/examples/VirtualHubIpConfigurationPut.json

Examples of adding the autoscale config via powershell:
$autoscale = New-AzVirtualRouterAutoScaleConfiguration -MinCapacity 3
New-AzRouteServer -RouteServerName myRouteServer -ResourceGroupName myResourceGroup -Location eastus -HostedSubnet $subnetId -PublicIpAddress $publicIpAddress -VirtualRouterAutoScaleConfiguration $autoscale

$autoscale = New-AzVirtualRouterAutoScaleConfiguration -MinCapacity 3
Update-AzRouteServer -RouteServerName myRouteServer -ResourceGroupName ksteinmeyer-metricTesting1213 -VirtualRouterAutoScaleConfiguration $autoscale

9. Prerequisite to use this feature. Whitelisting subscription? Registering the feature for subscription? Is it available in public Azure?

The subscription will need to be whitelisted for the feature, please reach out over teams to ksteinmeyer to whitelist the subscription.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 6, 2025

Thank you for opening this issue, we will look into it.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Network az network vnet/lb/nic/dns/etc... label Jan 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jan 6, 2025
@yonzhan yonzhan added this to the Backlog milestone Jan 6, 2025
@yonzhan yonzhan added feature-request and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

No branches or pull requests

4 participants