Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue #574 #601

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: Fix issue #574 #601

merged 2 commits into from
Jan 7, 2025

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jan 4, 2025

Overview/Summary

Related Issues/Work Items

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 4, 2025 07:12
@tksh164 tksh164 requested a review from a team as a code owner January 4, 2025 07:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • tools/1_wara_collector.ps1: Language not supported
  • tools/Version.json: Language not supported
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Jan 4, 2025
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tksh164

@oZakari oZakari added the Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team label Jan 6, 2025
@oZakari oZakari requested a review from a team January 6, 2025 19:26
@kpoineal kpoineal merged commit 88c234b into main Jan 7, 2025
8 checks passed
@kpoineal kpoineal deleted the fix/issue574 branch January 7, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team
Projects
None yet
3 participants