Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balasana Theme :: Google Page Speed Tool errors. #7343

Closed
mdtanjid0 opened this issue Sep 6, 2023 · 3 comments
Closed

Balasana Theme :: Google Page Speed Tool errors. #7343

mdtanjid0 opened this issue Sep 6, 2023 · 3 comments
Labels
Accessibility Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Low [Theme] Balasana Triaged [Type] Bug Something isn't working

Comments

@mdtanjid0
Copy link

Quick summary

With the Balasana theme, it shows an error on Google Page Speed Insights tool Values assigned to role="" are not valid ARIA roles..

Steps to reproduce

  1. Install Balasana Theme: https://wordpress.com/theme/balasana/
  2. Add the primary menu.
  3. And check with the Google Page Speed Insights Tool: https://pagespeed.web.dev/analysis
  4. And check the error:
    Screen Shot on 2023-09-06 at 21:41:23

What you expected to happen

It shouldn't show this error, and the role value should be valid.

What actually happened

It shows an error as the role value indicates invalid by Google Page Speed Insights Tool.

Browser

No response

Context

#6697903-zen

Platform (Simple, Atomic, or both?)

Simple, Atomic

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

No response

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6697903-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Sep 6, 2023
@cuemarie
Copy link

cuemarie commented Sep 6, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
I activated Balasana on a brand new free WordPress.com site, and analyzed it using https://pagespeed.web.dev/

  • With a Primary Menu set, running the site through Google Page Speed insights has this ARIA warning appear under the Desktop analysis.

jjUMcn.png

Failing Elements noted:
div#page > header#masthead > nav#site-navigation > input#toggle
<input type="checkbox" role="button" aria-haspopup="true" id="toggle" class="hide-visually">

📌 ACTIONS

  • Retitling
  • Adding to Bug Scrub Planning board
  • Triage complete

@cuemarie cuemarie changed the title Balasana Theme :: Google Page Speed Tool errors. Balasana Theme may contain invalid ARIA roles Sep 6, 2023
@cuemarie cuemarie moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 6, 2023
@cuemarie cuemarie changed the title Balasana Theme may contain invalid ARIA roles Balasana Theme :: Google Page Speed Tool errors. Sep 6, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Scrub Planning Aug 27, 2024
@ash1eygrace
Copy link
Member

ash1eygrace commented Jan 23, 2025

Second Triage

I can't reproduce this anymore when adding a primary menu. Additionally, I checked the DOM after adding a primary navigation, and the navigation currently has the aria-labels set on the Main Nav, submenus, and the current page:

<nav id="site-navigation" class="main-navigation" aria-label="Main Navigation">

<div class="menu-primary-container"><ul id="menu-primary" class="main-menu" aria-label="submenu">

<a href="https://mysite.wordpress.com/" aria-current="page">Home</a></nav>

Additionally, Google Page Speed shows:

Image

Going to close this as it's no longer an issue.

@github-project-automation github-project-automation bot moved this from Needs triage to Done in Bug Scrub Planning Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Low [Theme] Balasana Triaged [Type] Bug Something isn't working
Development

No branches or pull requests

3 participants