-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove XVM pallet code #1303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing Ermal's comments
I'd also suggest to announce this somehow.
Maybe G' can help via builder's announcements.
Minimum allowed line rate is |
@ermalkaleci can you approve if request for change was fulfilled? |
@Dinonard @ipapandinas I guess we can merge this |
I'm waiting for @ipapandinas to merge his first PR into this repo as a member xD |
🎉 🥳 🤣 |
Pull Request Summary
XVM pallet code is removed from the codebase and Shibuya runtime. Since the pallet and the precompile don't write to storage independently, there's no Shibuya on-chain storage to clean up.
Here is the documentation clean up related PR: AstarNetwork/astar-docs#692
Closes #1299
Check list