-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fakeplayers incorrectly invalid with .
and +
#42
Comments
It looks like this token is being categorized as an NBT path. This is a recursive structure (with braces, etc) so it's not feasible to try and back-track after it see an invalid character at the very end. The underlying issue is that fakeplayers are sometimes impossible to distinguish between other types of tokens. It's worth noting that the grammar does indeed check for a fakeplayer before an NBT path. language-mcfunction/lib/src/grammars/version-agnostic.yaml Lines 371 to 376 in 04eeeaa
However, to avoid ambiguity, the version-agnostic grammar specifically requires one of the symbols language-mcfunction/lib/src/grammars/version-agnostic.yaml Lines 119 to 121 in 04eeeaa
So you should be able to tell the highlighter directly by appending, say, I'd say it's at least reasonable to expect an error to not be highlighted here, such as with an unquoted string. Not sure how to fix that quite yet though, since unquoted strings are a superset of NBT paths and must be processed afterwards. |
I think that's reasonable, a bit unfortunate ofc. I always use |
Bug report checklist:
[x] The language-mcfunction extension only provides syntax highlighting. Have you confirmed that your issue is with the syntax highlighting, and not other features such as squiggly underlines, warning indicators, and/or pop-ups?
[x] Ensure that you are able to reproduce the issue without any other datapack-related extensions enabled.
[x] Make sure you attach a screenshot to your bug report. Bug reports without a screenshot will be closed.
Describe the bug:
In this image, the fakeplayer, rx.EnderChest+ is marked as invalid when this is a completely valid fakeplayer name.
I've tested w/ DHP off and on, this seems like a syntax related issue
The text was updated successfully, but these errors were encountered: