-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braze/Appboy device-mode destination is ignoring the product_id field on the 'Order Completed' event. #25
Comments
@abdullah-kasim thanks for reaching out. I think this is possibly a bug on Segment's end, and I'll follow up in the ticket you linked & file a new on on https://github.com/segmentio/analytics-android The issue is that Braze is parsing fields from Segment-provided Similarly, it looks like |
@abdullah-kasim for now, I would continue to pass in See also segmentio/analytics-android#746 |
@abdullah-kasim Segment confirmed the bug and the workaround here segmentio/analytics-android#746 (comment) |
Unfortunately, we won't be able to use the workaround as that doesn't fix the issue where the But, just to give everyone reading a closure - we've decided to integrate the purchases directly rather than going through Segment - so Appboy integration set to false for the Order Completed event. This has been the best solution for us so far, as I'm experiencing issues with the IOS's device mode integration too, where purchases aren't being logged at all. I'm just mentioning this in passing, as I didn't investigate it as deep as I did for Android. Plus, Segment's device mode integration is even harder to debug for React Native - it's frequently falling back to cloud-mode if I'm on a debug build of my app on iOS, possibly due to a conflict with CodePush. The times when it did manage to use device-mode, I didn't investigate deep enough. Production builds work perfectly though. But, I digressed. |
@abdullah-kasim thanks for the followup and feedback. I filed another issue with Segment re quantity, but agree that going the native route seems like the best path forward for now. Let us know if there's anything else we can do to help. |
Copied from segmentio/analytics-react-native#277
Hello,
Upon sending the payload below, for the event 'Order Completed', I am getting the error
The productId is empty, not logging in-app purchase to Appboy.
in android'slogcat
. This is with verbose logging enabled on Appboy. It's not showing up on Braze's dashboard either.Interestingly, if I added
id
alongside theproduct_id
inside theproducts
array, it will log the purchases properly, without the above errorI created the above payload based on this document: https://segment.com/docs/connections/spec/ecommerce/v2/
Platform: react-native, Android
Android Appboy SDK version:
+--- com.appboy:android-sdk-base:{strictly 12.0.0} -> 12.0.0 (c)
Android Segment Analytics version:
+--- com.segment.analytics.android:analytics:{strictly 4.9.1-beta} -> 4.9.1-beta (c)
React Native
react-native-appboy-sdk: 1.26.0
React Native
@segment/analytics-react-native-appboy: 1.4.1
I've only tested this on Android. I'll update this issue once I've tested this on iOS.
Extra note: Niall Brennan from segment dropped a note from Segment support that the issue may be related to this line. https://github.com/Appboy/appboy-segment-android/blob/master/appboy-segment-integration/src/main/java/com/segment/analytics/android/integrations/appboy/AppboyIntegration.java#L263
EDIT: Worth noting that it's completely ignoring the
quantity
field, too - if quantity is 3, it shows up in the dashboard as 1, but I guess that means a ticket rename or a new ticket is needed? Leaving it here so that I remember.EDIT2: We've decided to integrate directly for this event. See #25 (comment) for further info.
The text was updated successfully, but these errors were encountered: