Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on Android #8

Open
rgoldiez opened this issue May 25, 2018 · 3 comments
Open

Prevent crash on Android #8

rgoldiez opened this issue May 25, 2018 · 3 comments

Comments

@rgoldiez
Copy link

I'm using this package and really like it. However, on Android it causes a crash unless you limit it's use to iOS (e.g. if ( Platform.OS === 'ios' ) ... ). Why not handle the non-iOS case within this package, to make it easier on the user?

@charlesvinette
Copy link
Member

@rgoldiez Thanks for your feedback, I will look into this!

@marianrick
Copy link

Does this repo still work for iOS only and crashes on Android? I am not a fan of simulating the iOS behaviour on Android as well, but it would be nice to seamless use this without repeating Platform.OS === 'ios' all the time.

I would love to add this to your repo, but I'm afraid that I'm not capable of that.

@charlesvinette
Copy link
Member

Hey @marianrick! Thanks for dropping by. I need to take some time to work on the library, at the moment you need to make the check but it's in the plans. SoonTM 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants