Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Vibration API for < iOS 10 #5

Open
Noitidart opened this issue Mar 7, 2018 · 9 comments
Open

Fallback to Vibration API for < iOS 10 #5

Noitidart opened this issue Mar 7, 2018 · 9 comments

Comments

@Noitidart
Copy link

Is it possible for a built in fallback if < iOS 10?

@charlesvinette
Copy link
Member

Hi Noitidart, thanks for the suggestion. I need to find some time to update the lib, but I will keep that in mind. Thanks!

@Noitidart
Copy link
Author

Thank you for being so open! :)

@charlesvinette
Copy link
Member

Haha not a problem, I appreciate the feedback

@konjoinfinity
Copy link

konjoinfinity commented Nov 4, 2019

I've added this conditional to our app for now:

Platform.OS === "ios" && parseInt(Platform.Version, 10) >= 10 ? ReactNativeHaptic.generate('selection') : Vibration.vibrate()

Any plans to add Android haptics? This package is causes our app to crash but has Android support - https://github.com/milk-and-cookies-io/react-native-haptic-feedback

Would love to get Android haptics and I'd be willing to help build it out.

@charlesvinette
Copy link
Member

Hello Wesley! I would love that, feel free to make a PR and I will merge it in. Thank you!

@konjoinfinity
Copy link

Charles,

I'm currently writing custom Android vibration patterns to match the iOS haptic methods. I'm planning on submitting a PR in the near future.

@charlesvinette
Copy link
Member

Amazing @konjoinfinity, thank you for your contribution!

@konjoinfinity
Copy link

"Near future" means today haha

@charlesvinette
Copy link
Member

@konjoinfinity That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants