Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensmallen uses the term "neighbors" for directed graphs in a non-standard way #174

Open
cmungall opened this issue Sep 2, 2022 · 0 comments

Comments

@cmungall
Copy link
Contributor

cmungall commented Sep 2, 2022

For directed graphs, the term neighbors is used in a non-standard way

E.g.
https://www.cs.cmu.edu/afs/cs/academic/class/15210-f14/www/lectures/graph-intro.pdf

Neighbors. A vertex u is a neighbor of (or equivalently adjacent to) a vertex v in a graph
G = (V, E) if there is an edge {u, v} ∈ E. For a directed graph a vertex u is an in-neighbor of
a vertex v if (u, v) ∈ E and an out-neighbor if (v, u) ∈ E. We also say two edges or arcs are
neighbors if they share a vertex

So I would understand neighbors to mean the union of in and out neighbors, but ensmallen uses neighbors to mean out-neighbors.

I don't think the method name should change as that would break code, but I think there should be a simple glossary published in this repo that explains the terminology in the methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant